* Daniel M. <danny_mk at yahoo.com> [12 Aug 2004 14:24]: > The modifications to the scoop code are marked by > "#::CHANGE DM". If anyone of you has a better way of > doing this or other suggestions don't be affraid to > yell my way :-) Well, I have one suggestion right away - when submitting patches, please submit diffs, that way your changes are clearly marked in a standard way, and it's easier to see what's going on. From the base Scoop directory: cvs diff -u >/path/to/file.diff Then attach file.diff - this will list all the changes you've made, anywhere in the Scoop directory tree, compared to what's in CVS at the moment. Also, another good place to post feature requests and patches is at the Scoop Bug Muncher (http://bugz.mostly-harmless.ca/). And my final suggestion for this email: if you haven't already, I strongly suggest checking out the Scoop Admin Guide. The section on Scoop development (section 5) is still pretty small, but it has some information on how Scoop is put together and how to work with it, as well as how to submit patches. > By the way, shouldn't the following conditions be evaluated only once? > <snip login sanity checks> Yes - as shown in the comments, these are each different error conditions. They should really have different error messages letting the user know what went wrong. -- -janra | http://www.write-on.indy/ (OpenNIC) Who needs to be big and burly when | http://www.write-on.org/ (ICANN) you can just apply physics? | Discuss the art and craft of writing