As I said in my email reply to Vlad, I thought stopping people who
shouldn't be able to see the comment from rating hidden comments would
be a good fix.
To my surprise the code was already there (yey!) but it didn't work
(Doh!).
So I've fixed it, here's a patch. Please apply.
P.S. Sourceforge is acting really shitty at the moment, when are we
going to the new CVS server?
-------------- next part --------------
Index: lib/Scoop/Comments/Rate.pm
===================================================================
RCS file: /cvsroot/scoop/scoop/lib/Scoop/Comments/Rate.pm,v
retrieving revision 1.23
diff -c -r1.23 Rate.pm
*** lib/Scoop/Comments/Rate.pm 14 May 2003 19:46:51 -0000 1.23
--- lib/Scoop/Comments/Rate.pm 28 Jul 2003 11:30:14 -0000
***************
*** 186,192 ****
my $S = shift;
my ($sid, $cid, $rating) = @_;
my $sys_rate = shift;
-
# Rating range check
$rating = $S->_verify_rating($rating);
--- 186,191 ----
***************
*** 200,206 ****
return unless (defined($test_uid));
return $comm_uid if ($test_uid == $uid);
! return $comm_uid unless ($S->_check_rating_perm($sid, $cid) || $sys_rate);
#return if ($rating == 0);
my ($rv, $sth);
--- 199,206 ----
return unless (defined($test_uid));
return $comm_uid if ($test_uid == $uid);
! return $comm_uid unless ($S->_check_rating_perm($sid, $cid));
! return $comm_uid unless $sys_rate;
#return if ($rating == 0);
my ($rv, $sth);
***************
*** 393,401 ****
}
# Check if the comment is hidden, and if so, do you have permission ot rate it
! if (($row->{points} < $S->{UI}->{VARS}->{rating_min}) &&
! ($S->{TRUSTLEV} != 2) &&
! (!$S->have_perm('super_mojo'))) {
# No permissiuon to view == no permission to rate
return 0;
}
--- 393,400 ----
}
# Check if the comment is hidden, and if so, do you have permission ot rate it
! if ( ($row->{points} < $S->{UI}->{VARS}->{rating_min}) &&
! !( ($S->{TRUSTLEV} == 2) || ($S->have_perm('super_mojo')))) {
# No permissiuon to view == no permission to rate
return 0;
}