Commit info for scoop/struct/patch-files/current:
Modified Files:
README
Added Files:
script-21-post.pl patch-21-MoreChanges.sql
Log Message:
More bug fixes. The list is below. I also cleaned up some HTML in the code as I
went over it, but that was pretty minor. This is just copied out of the list I
was working off of, it might not make any sense.
code changes:
| if hide_rating_value is 0 or blank, min_rating - 1 is used. if min_rating
isn't 1, then there's no way to get hide_rating to be 0
| op=user;tool=prefs;uid=1 doesn't work anymore (editing user info)
| safe_mode should send back a 503 Service Unavailable
| requesting a non-existent user doesn't display an error message
| file uploads page shows subdirs as files. should not show them, or allow
using them
| autoformat won't linkify bars URLs anymore
| key impressions is requested by all ad emails but doesn't exist in db and
isn't used
| subscribe block isn't used anymore (hardcoded in Subscription.pm)
| subscribe_intro_text has a default code value, but it's duplicated in the
default database
| when creating a new ad template, properties get set but it can't be active
until an example ad is created, and it displays that error even if the admin
didn't try to mark it active
| in Ads::Submit, in structure on line 50: the value '5' isn't caught
| mail_ad_almost_done and mail_ad_done (and other blocks that use
escape_adjudge_mail) can only handle k5 style ads, even though the code can
handle other keys
| blocks admin tool needs /g on its description interpolate regexp
| digest_subjects is a block, but cron.pm looks in vars
| in the comment block, the special key "user_info" contains the value of the
special key "edit_user", even though "edit_user" is recognised as a separate
special key
| the mark_<group> blocks are only applied if subscriptions are on
| auto-post uses 4 queries to get votes instead of just one:
select count(vote) as score,vote,section_only from storymoderate where
sid='$sid' group by vote,section_only
| when calculating comment score, 1 is hard coded as the hidden comment
threshold instead of using the rating_min var
| upload_max_file_size in Utility.pm should be enforced (make sure $size isn't
greater, then only read in $size bytes)
| advertiser_group/req_extra_advertiser_info needs to work.
(/newuser/advertiser needs to be an op template to work)
| site controls links don't always work. model after blocks
(admin/tool/mode/item, not admin/tool/category)
| need instructions/link to blocks for creating a new ad template
| when editting a single block, links to other themes should take you to that
same block. if no block in that theme, blank form
| topics interface should use a checkbox to delete (like sections does)
database changes:
| user op EVAL needs a $p->{uid} = $uid; near the end
| user_box needs to test upload_user and upload_admin perms to add 'Your Files'
| story_info uses a special key (comment_controls) that isn't recognized. that
needs to be removed, as it's added elsewhere
| in poll_block, |hotlist| is used but it apparently isn't a valid key. |info|
isn't used either. remove these from the default
| block comment needs to have %%user_info%% changed to %%user_info%%
%%edit_user%%
| update admin/vars op template to be /tool/mode/item
| hook var needs update. user_new(username, is_advertiser) is the new one
| old box ops need to be converted to new format: buyimpressions_box,
fzdisplay,
renewad_box, submit_rdf. "This is a pretty easy change, just put that box
name
in the op definition, indicate that it's a box, and set the page template to
default_template or something similar. Then delete the four page template
blocks that were used before."
| subpay_paypal and ad_pay_paypal have paypal account name/email hard-coded in
boxes. should be a var
| submit_ad_pay_box should show whichever payment options have been turned on
by ads_use_cc and ads_use_paypal, instead of neither
| set newuser's template to /tool/
| poll_archive cron should run every 1M, not 1m
| pendingstory_bg isn't used in any code or box (remove it)
| missing blocks (in code only): donate_email_pledge, donate_email_success,
next_previous_links, rating_format
| in patches but missing from scoop.sql: author_edit_instructions
| comment_toggle(sid,cid,tool), file_upload(path), and user_confirm(nick)
missing from hook var
| block poll_box isn't used box poll_box's template (it uses plain). remove
poll_box block
| remove poll_guidelines, preview_text_ad_template, renew_confirm_message
| ads_use_cc and ads_use_payal (vars) don't exist. needed for payments
| remove column comment from storymoderate
Index: README
===================================================================
RCS file: /cvs/scoop/scoop/struct/patch-files/current/README,v
retrieving revision 1.82
retrieving revision 1.83
diff -r1.82 -r1.83
111a112,126
> Nov 26 19:37 patch-18-AdPayOptions.sql
> Adds vars to control payment options.
>
> Dec 18 19:45 patch-19-WhosOnline.sql
> Updated who's online code, using a table.
>
> Dec 31 02:11 patch-20-OpToBlock.sql
> Moves op HTML to blocks.
>
> Jan 18 04:30 patch-21-MoreChanges.sql
> Fixes additional bugs by adding and removing vars/blocks/etc.
>
> Jan 18 04:30 script-21-post.pl
> Fixes several bugs in boxes and op templates.
>